Il 09/03/2012 16:24, Anthony Liguori ha scritto: >> At the very least dump the inquiry pages, mode pages, etc. and see that >> they make sense and correspond to the device properties. > > Is this not something that's reasonably easy to do in qtest?
Yes (at least with virtio-scsi the libos bits are relatively small; just think of what it would have been like when the only HBA was LSI), but with one gotcha... > Is it possible to write a C program that does the ioctl and dump the > inquiry page in a text format conducive to shell parsing? ... sg_utils also parses the pages and dumps them in human-readable format. This is useful because it provides a completely separate implementation and avoids problems with misinterpretation of the standard. Of course it would work just as well if someone wrote tests instead of me. >>> Are these the sort of tests that would be interesting to also run on >>> Fedora, Windows, and Ubuntu? >> >> They should give exactly the same output on any guest. > > Is it valuable to have a per-platform test or since this is mostly > passthrough to the device (I assume), do you just need a single test? Ah, understood. Yeah, a single test is enough for the purpose of testing QEMU. If you want to test the driver too, running under Windows would be useful. Paolo
