On Wed, Nov 22, 2023 at 9:05 AM Markus Armbruster <arm...@redhat.com> wrote: > > John Snow <js...@redhat.com> writes: > > > There are two related changes here: > > > > (1) We need to perform type narrowing for resolving the type of > > tag_member during check(), and > > > > (2) tag_member is a delayed initialization field, but we can hide it > > behind a property that raises an Exception if it's called too > > early. This simplifies the typing in quite a few places and avoids > > needing to assert that the "tag_member is not None" at a dozen > > callsites, which can be confusing and suggest the wrong thing to a > > drive-by contributor. > > > > Signed-off-by: John Snow <js...@redhat.com> > > Without looking closely: review of PATCH 10 applies, doesn't it? >
Yep!
