Re: [PATCH] system: Use &error_abort in memory_region_init_ram_[device_]ptr()

[David Hildenbrand]

On 20.11.23 14:31, Philippe Mathieu-Daudé wrote:

If an unexpected error condition happens, we have to abort
(&fatal_error is meant for expected errors).

Suggested-by: Paolo Bonzini <pbonz...@redhat.com>
Suggested-by: Markus Armbruster <arm...@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org>
---
  system/memory.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/system/memory.c b/system/memory.c
index 304fa843ea..4d9cb0a7ff 100644
--- a/system/memory.c
+++ b/system/memory.c
@@ -1692,7 +1692,7 @@ void memory_region_init_ram_ptr(MemoryRegion *mr,

/* qemu_ram_alloc_from_ptr cannot fail with ptr != NULL. */

      assert(ptr != NULL);
-    mr->ram_block = qemu_ram_alloc_from_ptr(size, ptr, mr, &error_fatal);
+    mr->ram_block = qemu_ram_alloc_from_ptr(size, ptr, mr, &error_abort);
  }

void memory_region_init_ram_device_ptr(MemoryRegion *mr,

@@ -1711,7 +1711,7 @@ void memory_region_init_ram_device_ptr(MemoryRegion *mr,

/* qemu_ram_alloc_from_ptr cannot fail with ptr != NULL. */

      assert(ptr != NULL);
-    mr->ram_block = qemu_ram_alloc_from_ptr(size, ptr, mr, &error_fatal);
+    mr->ram_block = qemu_ram_alloc_from_ptr(size, ptr, mr, &error_abort);
  }

void memory_region_init_alias(MemoryRegion *mr,

Reviewed-by: David Hildenbrand <da...@redhat.com>

--
Cheers,

David / dhildenb