On 03/07/2012 05:40 AM, Stefan Hajnoczi wrote: > On Wed, Mar 7, 2012 at 12:16 PM, Peter Maydell <peter.mayd...@linaro.org> > wrote: >> Use the same mechanism we use for printing the configure command >> line to config-host.mak to print it to config.log. This fixes a >> bug where the config.log version didn't quote arguments with spaces. >> >> Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> >> --- >> If I'd noticed when I was adding the banner to config.log that we already >> printed this in config-host.mak I'd have done it this way to start with... >> >> configure | 4 +++- >> 1 files changed, 3 insertions(+), 1 deletions(-) >> >> diff --git a/configure b/configure >> index a5eb832..1b63436 100755 >> --- a/configure >> +++ b/configure >> @@ -22,7 +22,9 @@ rm -f config.log >> >> # Print a helpful header at the top of config.log >> echo "# QEMU configure log $(date)" >> config.log >> -echo "# produced by $0 $*" >> config.log
This left a trailing newline, >> +printf "# Configured with:" >> config.log >> +printf " '%s'" "$0" "$@" >> config.log but this does not. You probably want to add another echo afterwards, so that the next line of the log doesn't look like another configure argument. -- Eric Blake ebl...@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
