On Thu, Nov 09, 2023 at 01:58:55PM -0300, Fabiano Rosas wrote:
> We're not currently reporting the errors set with migrate_set_error()
> when incoming migration fails.
>
> Signed-off-by: Fabiano Rosas <faro...@suse.de>
> ---
> migration/migration.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index 28a34c9068..cca32c553c 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -698,6 +698,13 @@ process_incoming_migration_co(void *opaque)
> }
>
> if (ret < 0) {
> + MigrationState *s = migrate_get_current();
> +
> + if (migrate_has_error(s)) {
> + WITH_QEMU_LOCK_GUARD(&s->error_mutex) {
> + error_report_err(s->error);
> + }
> + }
What's the major benefit of dumping this explicitly?
And this is not relevant to the multifd problem, correct?
> error_report("load of migration failed: %s", strerror(-ret));
> goto fail;
> }
> --
> 2.35.3
>
--
Peter Xu
