>-----Original Message----- >From: Cédric Le Goater <c...@redhat.com> >Sent: Tuesday, November 7, 2023 10:37 PM >Subject: Re: [PATCH v4 25/41] Add iommufd configure option > >On 11/7/23 14:14, Cédric Le Goater wrote: >> On 11/2/23 08:12, Zhenzhong Duan wrote: >>> This adds "--enable-iommufd/--disable-iommufd" to enable or disable >>> iommufd support, enabled by default. >> >> I don't think a configure option is the right approach. I will >> comment other patches to propose another solution relying on >> Kconfig and activating IOMMUFD for aarch64, s390x, x86_64 only. > >Here is an example on your series : > > https://github.com/legoater/qemu/commits/vfio-8.2 > >The backend is always compiled (since it is common) but the VFIO frontend >and the 'iommufd' object are only available on x86_64, arm, s390x.
It looks like iommufd backend is compiled only for x86_64, arm or s390x, this makes sense for me, as I think on other platform which doesn't support iommufd, no need to compile useless iommufd backend in. > >Looks like a good compromise. Please tell me what you think about it. Yes, this looks better for me, I'll include your change in v5. Thanks Zhenzhong