Hi Igor, > From: Igor Mammedov <imamm...@redhat.com> > Sent: Friday, October 27, 2023 2:06 PM > To: Salil Mehta <salil.me...@huawei.com> > Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; m...@kernel.org; jean- > phili...@linaro.org; Jonathan Cameron <jonathan.came...@huawei.com>; > lpieral...@kernel.org; peter.mayd...@linaro.org; > richard.hender...@linaro.org; andrew.jo...@linux.dev; da...@redhat.com; > phi...@linaro.org; eric.au...@redhat.com; oliver.up...@linux.dev; > pbonz...@redhat.com; m...@redhat.com; w...@kernel.org; gs...@redhat.com; > raf...@kernel.org; alex.ben...@linaro.org; li...@armlinux.org.uk; > dar...@os.amperecomputing.com; il...@os.amperecomputing.com; > vis...@os.amperecomputing.com; karl.heub...@oracle.com; > miguel.l...@oracle.com; salil.me...@opnsrc.net; zhukeqian > <zhukeqi...@huawei.com>; wangxiongfeng (C) <wangxiongfe...@huawei.com>; > wangyanan (Y) <wangyana...@huawei.com>; jiakern...@gmail.com; > maob...@loongson.cn; lixiang...@loongson.cn; Linuxarm <linux...@huawei.com> > Subject: Re: [PATCH V6 3/9] hw/acpi: Add ACPI CPU hotplug init stub > > On Fri, 13 Oct 2023 11:51:23 +0100 > Salil Mehta <salil.me...@huawei.com> wrote: > > > ACPI CPU hotplug related initialization should only happen if > > ACPI_CPU_HOTPLUG > > support has been enabled for particular architecture. Add > > cpu_hotplug_hw_init() > > stub to avoid compilation break. > > merge this with 4/9 that actually requires this to be done.
Sure. No issues. Thanks Salil. > > Signed-off-by: Salil Mehta <salil.me...@huawei.com> > > Reviewed-by: Jonathan Cameron <jonathan.came...@huawei.com> > > Reviewed-by: Gavin Shan <gs...@redhat.com> > > Reviewed-by: Shaoqin Huang <shahu...@redhat.com> > > Tested-by: Vishnu Pajjuri <vis...@os.amperecomputing.com> > > Tested-by: Xianglai Li <lixiang...@loongson.cn> > > --- > > hw/acpi/acpi-cpu-hotplug-stub.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/hw/acpi/acpi-cpu-hotplug-stub.c b/hw/acpi/acpi-cpu-hotplug- > stub.c > > index 3fc4b14c26..c6c61bb9cd 100644 > > --- a/hw/acpi/acpi-cpu-hotplug-stub.c > > +++ b/hw/acpi/acpi-cpu-hotplug-stub.c > > @@ -19,6 +19,12 @@ void legacy_acpi_cpu_hotplug_init(MemoryRegion > *parent, Object *owner, > > return; > > } > > > > +void cpu_hotplug_hw_init(MemoryRegion *as, Object *owner, > > + CPUHotplugState *state, hwaddr base_addr) > > +{ > > + return; > > +} > > + > > void acpi_cpu_ospm_status(CPUHotplugState *cpu_st, ACPIOSTInfoList > ***list) > > { > > return; >