On Thu, Oct 05, 2023 at 12:29:22PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > Main thing this series does is DEVICE_ON event - a counter-part to > DEVICE_DELETED. A guest-driven event that device is powered-on. > Details are in patch 2. The new event is paried with corresponding > command query-hotplug.
Several things questionable here: 1. depending on guest activity you can get as many DEVICE_ON events as you like 2. it's just for shpc and native pcie - things are confusing enough for management, we should make sure it can work for all devices 3. what about non hotpluggable devices? do we want the event for them? I feel this needs actual motivation so we can judge what's the right way to do it. > > v8: > - improve naming, wording and style > - make new QMP interface experimental > > > Vladimir Sementsov-Ogievskiy (4): > qapi/qdev.json: unite DEVICE_* event data into single structure > qapi: add DEVICE_ON and query-hotplug infrastructure > shpc: implement DEVICE_ON event and query-hotplug > pcie: implement DEVICE_ON event and query-hotplug > > hw/core/hotplug.c | 12 +++ > hw/pci-bridge/pci_bridge_dev.c | 14 +++ > hw/pci-bridge/pcie_pci_bridge.c | 1 + > hw/pci/pcie.c | 83 +++++++++++++++ > hw/pci/pcie_port.c | 1 + > hw/pci/shpc.c | 86 +++++++++++++++ > include/hw/hotplug.h | 11 ++ > include/hw/pci/pci_bridge.h | 2 + > include/hw/pci/pcie.h | 2 + > include/hw/pci/shpc.h | 2 + > include/hw/qdev-core.h | 7 ++ > include/monitor/qdev.h | 6 ++ > qapi/qdev.json | 178 +++++++++++++++++++++++++++++--- > softmmu/qdev-monitor.c | 58 +++++++++++ > 14 files changed, 451 insertions(+), 12 deletions(-) > > -- > 2.34.1
