Dinah B <dinahbaum...@gmail.com> writes: > Hi, > > I noticed that qapi now has a machine-common category - do you think these > changes would be more appropriate in that file > rather than "machine" for the revision?
You're right. We created machine-common.json for stuff needed by both machine.json and machine-target.json. The alternative was to have machine-target.json include machine.json instead. When we discussed which alternative to pick, I didn't remember your patch adds the include. Picking both makes no sense. Please look into adding stuff in a way that avoids the include. Thanks for paying attention! > Thanks and sorry for the delay, I'm not in a hurry here :)