On 10/25/23 00:33, Philippe Mathieu-Daudé wrote:
Hi Nicholas,
On 25/10/23 09:09, Nicholas Piggin wrote:
On Tue Oct 24, 2023 at 11:04 AM AEST, Richard Henderson wrote:
On 10/23/23 09:09, Philippe Mathieu-Daudé wrote:
Inspired-by: Richard Henderson <richard.hender...@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org>
---
RFC: Please double-check 32/64 & bits
---
target/ppc/translate.c | 22 ++++------------------
1 file changed, 4 insertions(+), 18 deletions(-)
diff --git a/target/ppc/translate.c b/target/ppc/translate.c
index c6e1f7c2ca..1370db9bd5 100644
--- a/target/ppc/translate.c
+++ b/target/ppc/translate.c
@@ -2892,13 +2892,7 @@ static void gen_slw(DisasContext *ctx)
t0 = tcg_temp_new();
/* AND rS with a mask that is 0 when rB >= 0x20 */
-#if defined(TARGET_PPC64)
- tcg_gen_shli_tl(t0, cpu_gpr[rB(ctx->opcode)], 0x3a);
- tcg_gen_sari_tl(t0, t0, 0x3f);
-#else
- tcg_gen_shli_tl(t0, cpu_gpr[rB(ctx->opcode)], 0x1a);
- tcg_gen_sari_tl(t0, t0, 0x1f);
-#endif
+ tcg_gen_sextract_tl(t0, cpu_gpr[rB(ctx->opcode)], 5, 1);
tcg_gen_andc_tl(t0, cpu_gpr[rS(ctx->opcode)], t0);
Patch looks correct as is, so
Reviewed-by: Richard Henderson <richard.hender...@linaro.org>
Reviewed-by: Nicholas Piggin <npig...@gmail.com>
So are you OK to take this patch as-is as a first iteration?
I am, yes. The simple fact of the ifdef removal is worth it.
r~
