Cong Liu <liuco...@kylinos.cn> writes:
> This patch closes the file descriptor fd on error return to avoid
> resource leak.
>
> Fixes: ec7ee95db909 ("contrib/plugins: fix coverity warning in lockstep")
> Signed-off-by: Cong Liu <liuco...@kylinos.cn>
> ---
> contrib/plugins/lockstep.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c
> index f0cb8792c6fa..237543b43a76 100644
> --- a/contrib/plugins/lockstep.c
> +++ b/contrib/plugins/lockstep.c
> @@ -257,6 +257,7 @@ static bool setup_socket(const char *path)
> sockaddr.sun_family = AF_UNIX;
> if (g_strlcpy(sockaddr.sun_path, path, pathlen) >= pathlen) {
> perror("bad path");
> + close(fd);
> return false;
> }
>
> @@ -303,6 +304,7 @@ static bool connect_socket(const char *path)
> sockaddr.sun_family = AF_UNIX;
> if (g_strlcpy(sockaddr.sun_path, path, pathlen) >= pathlen) {
> perror("bad path");
> + close(fd);
> return false;
> }
Sorry queued this version to plugins/next, thanks.
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
