marcandre.lur...@redhat.com writes: > From: Marc-André Lureau <marcandre.lur...@redhat.com> > > error_vprintf() is implemented in monitor.c, which overrides the > default implementation from stubs/, while avoiding a direct dependency > to the monitor from error-report.c. > > However, the stub solution isn't working when moving error-report.c and > stubs/error-printf.c in a common library. Linking with such library > creates conflicts for the error_vprintf() implementations
I'm feeling dense today: how? Why would the linker pull in error-printf.o when the symbols it defines are already provided by .o the linker processed before the library containing error-printf.o? > (and weak > symbols aren't great either). Weak symbols are great, except Windows isn't. > Instead, use the "traditional" approach to > provide overidable callbacks. > > Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com>
