On Tue, Nov 16, 2021 at 01:28:19PM -0800, Keith Busch wrote: > On Tue, Nov 16, 2021 at 04:34:39PM +0100, Łukasz Gieryk wrote: > > if (!pci_is_vf(&n->parent_obj) && n->params.sriov_max_vfs) { > > - pcie_sriov_pf_disable_vfs(&n->parent_obj); > > + if (rst != NVME_RESET_CONTROLLER) { > > + pcie_sriov_pf_disable_vfs(&n->parent_obj); > > Shouldn't this be 'if (rst == NVME_RESET_FUNCTION)'?
The NVMe Spec lists five possible reset types (triggers). According to my understanding, only the Controller Reset doesn’t affect the VFs' state, hence the '!='.