Am 06.10.2021 um 15:00 hat Emanuele Giuseppe Esposito geschrieben:
> Test 297 in qemu-iotests folder currently fails: pylint has
> learned new things to check, or we simply missed them.
>
> All fixes in this patch are related to additional spaces used
> or wrong indentation.
>
> No functional change intended.
>
> Signed-off-by: Emanuele Giuseppe Esposito <eespo...@redhat.com>
> @@ -87,13 +87,14 @@ class TestStopWithBlockJob(iotests.QMPTestCase):
> iotests.qemu_img('create', '-f', iotests.imgfmt, self.overlay_img,
> '1G')
>
> - result = self.vm.qmp('blockdev-add', **{
> + result = self.vm.qmp('blockdev-add',
> + **{
> 'node-name': 'overlay',
> 'driver': iotests.imgfmt,
> 'file': {
> 'driver': 'file',
> 'filename': self.overlay_img
> - }
> + }
> })
> self.assert_qmp(result, 'return', {})
Am I the only one to think that the new indentation for the closing
brace there is horrible? PEP-8 explictly allows things like:
my_list = [
1, 2, 3,
4, 5, 6,
]
Some of the other changes in this patch should be made, but at least if
these are behind different switches, I would consider just disabling the
one that complains about nicely formatted dicts.
Kevin
