Per
https://discourse.gnome.org/t/port-your-module-from-g-memdup-to-g-memdup2-now/5538
The old API took the size of the memory to duplicate as a guint,
whereas most memory functions take memory sizes as a gsize. This
made it easy to accidentally pass a gsize to g_memdup(). For large
values, that would lead to a silent truncation of the size from 64
to 32 bits, and result in a heap area being returned which is
significantly smaller than what the caller expects. This can likely
be exploited in various modules to cause a heap buffer overflow.
g_memdup() as been deprecated in GLib 2.68. Since QEMU defines
GLIB_VERSION_MAX_ALLOWED to GLIB_VERSION_2_56, the deprecation
is not displayed (on GLib >= 2.68 such available on Fedora 34).
However the function is still unsafe, so it is better to avoid
its use.
This series provides the safely equivalent g_memdup2_qemu()
wrapper, and replace all g_memdup() calls by it.
The previous link recommend to audit the call sites. Most of the
calls use byte_size=sizeof(STRUCT), and no STRUCT appears to be
> 4GiB. Few calls use unsigned/size_t/uint16_t. Where code is
doing multiplication, patches are sent as RFC. In particular:
hw/net/virtio-net.c
hw/virtio/virtio-crypto.c
Please review,
Phil.
Philippe Mathieu-Daudé (28):
hw/hyperv/vmbus: Remove unused vmbus_load/save_req()
glib-compat: Introduce g_memdup2() wrapper
qapi: Replace g_memdup() by g_memdup2_qemu()
accel/tcg: Replace g_memdup() by g_memdup2_qemu()
block/qcow2-bitmap: Replace g_memdup() by g_memdup2_qemu()
softmmu: Replace g_memdup() by g_memdup2_qemu()
hw/9pfs: Replace g_memdup() by g_memdup2_qemu()
hw/acpi: Avoid truncating acpi_data_len() to 32-bit
hw/acpi: Replace g_memdup() by g_memdup2_qemu()
hw/core/machine: Replace g_memdup() by g_memdup2_qemu()
hw/hppa/machine: Replace g_memdup() by g_memdup2_qemu()
hw/i386/multiboot: Replace g_memdup() by g_memdup2_qemu()
hw/net/eepro100: Replace g_memdup() by g_memdup2_qemu()
hw/nvram/fw_cfg: Replace g_memdup() by g_memdup2_qemu()
hw/scsi/mptsas: Replace g_memdup() by g_memdup2_qemu()
hw/ppc/spapr_pci: Replace g_memdup() by g_memdup2_qemu()
hw/rdma: Replace g_memdup() by g_memdup2_qemu()
hw/vfio/pci: Replace g_memdup() by g_memdup2_qemu()
RFC hw/virtio: Replace g_memdup() by g_memdup2_qemu()
net/colo: Replace g_memdup() by g_memdup2_qemu()
RFC ui/clipboard: Replace g_memdup() by g_memdup2_qemu()
RFC linux-user: Replace g_memdup() by g_memdup2_qemu()
tests/unit: Replace g_memdup() by g_memdup2_qemu()
tests/qtest: Replace g_memdup() by g_memdup2_qemu()
target/arm: Replace g_memdup() by g_memdup2_qemu()
target/ppc: Replace g_memdup() by g_memdup2_qemu()
contrib: Replace g_memdup() by g_memdup2_qemu()
checkpatch: Do not allow deprecated g_memdup()
include/glib-compat.h | 36 ++++++++++++++++++++++
include/hw/hyperv/vmbus.h | 3 --
accel/tcg/cputlb.c | 8 ++---
block/qcow2-bitmap.c | 2 +-
contrib/plugins/lockstep.c | 2 +-
contrib/rdmacm-mux/main.c | 10 +++----
hw/9pfs/9p-synth.c | 2 +-
hw/9pfs/9p.c | 2 +-
hw/acpi/core.c | 3 +-
hw/arm/virt-acpi-build.c | 2 +-
hw/core/machine.c | 4 +--
hw/hppa/machine.c | 8 ++---
hw/hyperv/vmbus.c | 59 -------------------------------------
hw/i386/acpi-build.c | 6 ++--
hw/i386/multiboot.c | 2 +-
hw/net/eepro100.c | 2 +-
hw/net/virtio-net.c | 3 +-
hw/nvram/fw_cfg.c | 9 +++---
hw/ppc/spapr_pci.c | 8 ++---
hw/rdma/rdma_utils.c | 2 +-
hw/scsi/mptsas.c | 5 ++--
hw/vfio/pci.c | 2 +-
hw/virtio/virtio-crypto.c | 7 +++--
linux-user/syscall.c | 2 +-
linux-user/uaccess.c | 2 +-
net/colo.c | 4 +--
qapi/qapi-clone-visitor.c | 16 +++++-----
qapi/qapi-visit-core.c | 6 ++--
softmmu/memory.c | 2 +-
softmmu/vl.c | 2 +-
target/arm/helper.c | 7 +++--
target/ppc/mmu-hash64.c | 3 +-
tests/qtest/libqos/ahci.c | 6 ++--
tests/qtest/libqos/qgraph.c | 2 +-
tests/unit/ptimer-test.c | 22 +++++++-------
tests/unit/test-iov.c | 26 ++++++++--------
ui/clipboard.c | 2 +-
scripts/checkpatch.pl | 5 ++++
38 files changed, 141 insertions(+), 153 deletions(-)
--
2.31.1
