On 4/9/21 12:07 PM, Emanuele Giuseppe Esposito wrote:
diff --git a/python/qemu/machine.py b/python/qemu/machine.py
index c721e07d63..18d32ebe45 100644
--- a/python/qemu/machine.py
+++ b/python/qemu/machine.py
@@ -109,7 +109,7 @@ def __init__(self,
self._binary = binary
self._args = list(args)
- self._wrapper = wrapper
+ self._wrapper = list(wrapper)
Unrelated change?
(I'm assuming you want to copy the user's input to explicitly avoid
sharing state. Commit message blurb for this would be good.)
Yes, unrelated change. I do not see the benefit of copying the user
state. I will drop it.
ACK
(Apologies for the ignorance, is this an Acked-by?)
Emanuele
Ah, yes. I just mean to say: "Minor style stuff, but looks good to me
and I'll [likely] approve the non-RFC versions of these."
(Pending tests passing via flake8/pylint/mypy. Sorry those aren't
formalized in the tree yet.)
--js
