Chen Qun <[email protected]> 于2020年10月10日周六 下午7:08写道： > > This if statement judgment is redundant and it will cause a warning: > > migration/block-dirty-bitmap.c:1090:13: warning: ‘bitmap_name’ may be used > uninitialized in this function [-Wmaybe-uninitialized] > g_strlcpy(s->bitmap_name, bitmap_name, sizeof(s->bitmap_name)); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Reported-by: Euler Robot <[email protected]> > Signed-off-by: Chen Qun <[email protected]>
Reviewed-by: Li Qiang <[email protected]> > --- > migration/block-dirty-bitmap.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/migration/block-dirty-bitmap.c b/migration/block-dirty-bitmap.c > index 5bef793ac0..e09ea4f22b 100644 > --- a/migration/block-dirty-bitmap.c > +++ b/migration/block-dirty-bitmap.c > @@ -1084,9 +1084,7 @@ static int dirty_bitmap_load_header(QEMUFile *f, > DBMLoadState *s, > } else { > bitmap_name = s->bitmap_alias; > } > - } > > - if (!s->cancelled) { > g_strlcpy(s->bitmap_name, bitmap_name, sizeof(s->bitmap_name)); > s->bitmap = bdrv_find_dirty_bitmap(s->bs, s->bitmap_name); > > -- > 2.23.0 > >
