On 27/07/2020 22.07, Vladimir Sementsov-Ogievskiy wrote: > 27.07.2020 22:51, Eric Blake wrote: >> A quick run of './check -qcow2 -g migration' shows that test 169 is >> NOT quick, but meanwhile several other tests ARE quick. Let's adjust >> the test designations accordingly. >> >> Signed-off-by: Eric Blake <[email protected]> > > Reviewed-by: Vladimir Sementsov-Ogievskiy <[email protected]> > > Still, why do we need quick group? make check uses "auto" group.. > Some tests are considered important enough to run even not being quick. > Probably, everyone who don't want to run all tests, should run "auto" > group, not "quick"? > I, when want to check my changes, run all tests or limit them with > help of grep. I mostly run tests on tmpfs, so they all are quick enough. > Saving several minutes of cpu work doesn't worth missing a bug..
I think it still makes at least some sense: - "quick" is for tests that run fast on the developers systems (i.e. only Linux, I guess) - can be used during development for a quick check in between when you don't want to wait too long - "auto" group is for "make check", i.e. the test runs fine and reasonable fast on all systems (including macOS, *BSD and weird CI pipelines) - The full check should be done before submitting block-layer related code, to make sure that no regression happened Just my 0.02 €, of course. Thomas
