----- Original Message -----
> From: "Eric Blake" <[email protected]>
> To: "Cleber Rosa" <[email protected]>, [email protected]
> Cc: [email protected], "Max Reitz" <[email protected]>, "Kevin Wolf"
> <[email protected]>, [email protected],
> "Michael Tokarev" <[email protected]>, "Laurent Vivier" <[email protected]>
> Sent: Wednesday, October 9, 2019 3:51:56 PM
> Subject: Re: [PATCH v2 1/4] qemu-iotests: remove bash shebang from library
> files
>
> On 10/9/19 2:47 PM, Cleber Rosa wrote:
> > Due to not being able to find a reason to have shebangs on files that
> > are not executable.
> >
> > While at it, add a mode hint to emacs, which would be clueless or
> > plain wrong about these containing shell code.
> >
> > Suggested-by: Eric Blake <[email protected]>
> > Signed-off-by: Cleber Rosa <[email protected]>
> > ---
> > tests/qemu-iotests/common.config | 2 +-
> > tests/qemu-iotests/common.filter | 2 +-
> > tests/qemu-iotests/common.nbd | 3 +--
> > tests/qemu-iotests/common.pattern | 2 +-
> > tests/qemu-iotests/common.qemu | 2 +-
> > tests/qemu-iotests/common.rc | 2 +-
> > tests/qemu-iotests/common.tls | 2 +-
> > 7 files changed, 7 insertions(+), 8 deletions(-)
> >
> > diff --git a/tests/qemu-iotests/common.config
> > b/tests/qemu-iotests/common.config
> > index 9bd1a5a6fc..b85a6a6f96 100644
> > --- a/tests/qemu-iotests/common.config
> > +++ b/tests/qemu-iotests/common.config
> > @@ -1,4 +1,4 @@
> > -#!/usr/bin/env bash
> > +# -*- emacs mode: sh -*-
>
> I thought my version:
> # hey emacs, this file will be sourced by bash -*- mode: sh -*-
> was cuter, but that's not a requirement, and yours works ;)
>
I will not make any disputes on that! :)
Thanks for the reviews!
- Cleber.
> Reviewed-by: Eric Blake <[email protected]>
>
> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc. +1-919-301-3226
> Virtualization: qemu.org | libvirt.org
>
