On 10/7/19 7:05 AM, Max Reitz wrote:
On 24.09.19 16:35, Eric Blake wrote:
Log the QMP input to qemu, not just the QMP output.
Why not just add this functionality to _send_qemu_cmd directly? (Like
silent already does for replies, although it’s inverted.)
Interesting idea. I'll give it a shot (it may have a larger effect on
more .out files, but that's probably a good thing).
(Although I’m not quite sold on the indentation for commands, because
(1) we don’t do that in other tests, (2) I’d prefer some prefix like
->/<-, and (3) there is generally no need because commands start with
“execute” and replies start with “return”, “error”, or “event”, so they
already have clear prefixes to distinguish the two classes.)
I don't mind avoiding indentation; as you say, direction can be inferred
by contents.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
