On Mon, 5 Aug 2019 at 19:21, Max Reitz <[email protected]> wrote: > Would dropping the test patches make it better? :-) > > I am reasonably (i.e., rc4-levels of) confident that the patches don’t > break anything that wasn’t broken before. > > (I’m least confident about the test patches working for everyone and > everywhere, as with all new test cases. But it was my impression that > it’s always fine to include test case additions.) > > Patch 1 is very important. I’m very confident about it. > It fixes a silent corruption in the backup job, so I’m not too surprised > people haven’t noticed. I would be surprised if really noone was > affected so far. > > Patch 3 is not that important, but it is sufficiently simple, so I think > we should take it, even into rc4. > > Patch 5 is very important for a specific mirror copying mode. It can be > argued that nobody really uses this mode because otherwise somebody > should have noticed the corruption, because if you hit it, you will > simply lose data (as opposed to the backup case, where you will simply > get the wrong version of the data in the output image). > But that is why it’s so important. I really don’t want anyone to hit it. > It is probably the most complicated patch here, but at any other point, > it would still be considered a simple patch. (Just not quite trivial.) > I think it is worth taking it. > > Patch 7 is actually not important. But it’s an obvious trivial > one-liner. I thought I might as well.
Thanks for the clarifications -- these all sound worth taking. The thing about rc4 is that we don't really have much chance to find any problems with patches we put in at this point, so I like to be pretty cautious. thanks -- PMM
