On 1/23/19 12:34 PM, Max Reitz wrote: > On 23.01.19 14:05, Max Reitz wrote: >> On 21.01.19 21:50, John Snow wrote: > > [...] > >>> I guess my only other observation is that we have a lot of "while True" >>> loops now, is it worth creating some kind of helper that does the dirty >>> work of finding a serviceable port or nah? >> >> Seems reasonable, I'll see how it looks. > > If I do that, the diff stat looks to be 40+, 33-. Is that worth it? > > Max > Instead of: 1 file changed, 68 insertions(+), 30 deletions(-) Or in addition to? Use your own judg[e?]ment on it, I guess it's local to this one iotest for now anyway, so if it's not an obvious win just skip it. --js
- [Qemu-block] [PATCH 2/3] iotests: Bind qemu-nbd to lo... Max Reitz
- [Qemu-block] [PATCH 1/3] iotests.py: Add qemu_nbd_pip... Max Reitz
- [Qemu-block] [PATCH 3/3] iotests: Allow 147 to be run... Max Reitz
- Re: [Qemu-block] [PATCH 3/3] iotests: Allow 147 ... John Snow
- Re: [Qemu-block] [PATCH 3/3] iotests: Allow ... Max Reitz
- Re: [Qemu-block] [PATCH 3/3] iotests: Al... Max Reitz
- Re: [Qemu-block] [PATCH 3/3] iotests... John Snow
- Re: [Qemu-block] [PATCH 3/3] io... Max Reitz
- Re: [Qemu-block] [Qemu-devel] [PATCH 3/3] iotest... Eric Blake
- Re: [Qemu-block] [Qemu-devel] [PATCH 3/3] io... Max Reitz
- Re: [Qemu-block] [Qemu-devel] [PATCH 3/3... Eric Blake
- Re: [Qemu-block] [Qemu-devel] [PATCH... Daniel P . Berrangé
- Re: [Qemu-block] [Qemu-devel] [PATCH... Max Reitz
- Re: [Qemu-block] [PATCH 0/3] iotests: Allow 147 to be... Max Reitz
