On Tue 20 Nov 2018 07:21:21 PM CET, Kevin Wolf wrote: > Am 12.11.2018 um 15:00 hat Alberto Garcia geschrieben: >> Hi all, >> >> when reopening a BlockDriverState using bdrv_reopen() and friends the >> new options can be specified either with a QDict or with flags. Both >> methods overlap and that makes the semantics and the implementation >> unnecessarily complicated. >> >> This series removes the 'flags' parameter from these functions, so >> from now on all option changes must be specified using a QDict. Apart >> from simplifying the API, a few bugs are fixed along the way. See the >> individual patches for more details. >> >> This was tested with the current master (460f0236c12a86a38692c12d9bf). > > Looks good to me, except for that one s/int/bool/ that I could do while > applying. > > The only remaining question is - is all of this for 3.1, or which parts > are? It's a long series, but there are also a few bug fixes in there.
It wasn't meant for 3.1, I don't think there's any urgency for that. Patch 16 is perhaps worth applying now (and even patch 14), but the rest can wait. Berto
