On Thu, 02/23 13:25, Kevin Wolf wrote: > Am 23.02.2017 um 12:49 hat Fam Zheng geschrieben: > > On Tue, 02/21 15:58, Kevin Wolf wrote: > > > - backing = bdrv_new(); > > > + backing = bdrv_new_open_driver(&vvfat_write_target, NULL, > > > BDRV_O_ALLOW_RDWR, > > > + &error_abort); > > > + *(void**) backing->opaque = s; > > > > Could be simply "backing->opaque = s". > > That's not semantically the same. > > Or if you just mean that vvfat shouldn't be using an implicit > BdrvVVFATState with just one pointer element rather than just directly > assigning the pointer to bs->opaque, that might have been an option, but > vvfat isn't written that way and I don't intend to change it at least in > this specific patch. (If I were to change it, I would probably just use > an explicit BdrvVVFATState, though.)
OK, I see it now. Thanks! Fam
