These are both currently set to QEMU specific hardcoded defaults, and in common with other block devices, should allow user overrides.
The pre-existing serial field should also be length checked to detect & report invalid user input instead of silently truncating. Daniel P. Berrangé (4): include/block: define constants for NVME string fields hw/nvme: report error for oversized 'serial' parameter hw/nvme: add user controlled 'model' property hw/nvme: add user controlled 'firmware-version' property docs/system/devices/nvme.rst | 10 ++++++++++ hw/nvme/ctrl.c | 31 ++++++++++++++++++++++++++++--- hw/nvme/nvme.h | 2 ++ include/block/nvme.h | 10 +++++++--- 4 files changed, 47 insertions(+), 6 deletions(-) -- 2.53.0
