Am 28.11.2025 um 11:15 hat Paolo Bonzini geschrieben: > Rust bindings are roughly broken up according to subdirectories of > include/ (that's not exact, but it's roughly an aim). However, > block/aio.h contains both block layer-specific concepts (BlockAIOCB, > BlockCompletionFunc) and AioContext-related declarations that are > used be qemu/main-loop.h. > > Break out the latter into their own header file, and use that to > break the inclusion of block/ from qemu/main-loop.h. > > Signed-off-by: Paolo Bonzini <[email protected]> > --- > Based on top of > > https://lore.kernel.org/qemu-devel/[email protected]/ > > include/block/aio.h | 838 +------------------------------------- > include/qemu/aio.h | 852 +++++++++++++++++++++++++++++++++++++++ > include/qemu/main-loop.h | 4 +- > 3 files changed, 857 insertions(+), 837 deletions(-) > create mode 100644 include/qemu/aio.h
Is it really worth keeping a separate tiny include file for BlockAIOCB? Maybe let's have a patch to move it and its three functions to block-common.h, and then just move this file unchanged into the place where it should always have been. Kevin
