On Wed, Aug 06, 2025 at 10:56:31AM +0300, Michael Tokarev wrote: > Commit c0ddcb2cbc146e introduced the test which uses cache=direct > mode, without checking if the scratch filesystem supports O_DIRECT. > A subsequent commit, afeb002e0ad49d, tried to fix that issue, but > instead of checking for o_direct, it checked for > `_supported_cache_modes none directsync`, which is not what the > original mirror-sparse test uses. Fix both by actually checking > for o_direct. > > Fixes: c0ddcb2cbc146e "tests: Add iotest mirror-sparse for recent patches" > Fixes: afeb002e0ad49d "tests/qemu-iotests/tests/mirror-sparse: skip if > O_DIRECT is not supported" > Signed-off-by: Michael Tokarev <m...@tls.msk.ru> > --- > This is what happens when rushing for last-minute > pre-release fixes.. I'm sorry for this. > > tests/qemu-iotests/tests/mirror-sparse | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Please include this in a pull request for QEMU v10.1.0-rc3. Thanks! Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
signature.asc
Description: PGP signature