Am 10.04.2025 um 17:28 hat Paolo Bonzini geschrieben: > On Thu, Apr 10, 2025 at 4:25 PM Paolo Bonzini <pbonz...@redhat.com> wrote: > > You should set ret = 0 here to avoid going down the > > scsi_sense_from_errno() path. > > > > Otherwise, > > > > Reviewed-by: Paolo Bonzini <pbonz...@redhat.com> > > Okay, going down the scsi_sense_from_errno() path is more or less > harmless because status and sense end up unused; even though ENODEV is > not something that the function handles, that can be added as a > cleanup in 10.1.
Yes, it could be handled more explicitly. I considered adding a special if branch in scsi_handle_rw_error() for host_status != -1 before checking ret < 0, but didn't do it in the end because the existing code already handles it fine. If you prefer it to be there for readability, I can send a cleanup patch. Kevin
