Hi Paolo, > > On emscripten, function pointer casts can cause function call failure. > > This commit fixes the function definition to match to the type of the > > function call. > > > > - qtest_set_command_cb passed to g_once should match to GThreadFunc > > Sending an alternative patch that doesn't use GOnce, this code runs in > the main thread.
Thank you for addressing this issue. I've sent a review to that patch. > > - object_class_cmp and cpreg_key_compare are passed to g_list_sort as > > GCopmareFunc but GLib cast them to GCompareDataFunc. > > Please use g_list_sort_with_data instead, and poison > g_slist_sort/g_list_sort in include/glib-compat.h, with a comment > explaining that it's done this way because of Emscripten. Sure, I’ll fix this in the next version of the series.
