On Wed, Mar 26, 2025 at 03:35:33PM +0100, Thomas Huth wrote:
> From: Thomas Huth <th...@redhat.com>
>
> This reverts commit e2668ba1ed44ad56f2f1653ff5f53b277d534fac.
>
> This commit made test 162 fail occasionally with:
>
> 162 fail [13:06:40] [13:06:40] 0.2s (last: 0.2s) output mismatch
> --- tests/qemu-iotests/162.out
> +++ tests/qemu-iotests/scratch/qcow2-file-162/162.out.bad
> @@ -3,6 +3,7 @@
> === NBD ===
> qemu-img: Could not open 'json:{"driver": "nbd", "host": -1}': address
> resolution failed for -1:10809: Name or service not known
> image: nbd://localhost:PORT
> +./common.rc: line 371: kill: (891116) - No such process
> image: nbd+unix://?socket=42
>
> The nbd server should normally terminate automatically, so trying to
> kill it here now seems to cause a race that will cause a test failure
> when the server terminated before the kill command has been executed.
>
> The "Stop NBD server" patch has originally been written to solve another
> problem with a hanging nbd server, but since that problem has been properly
> solved by commit 3e1683485656, we now don't need the "_stop_nbd_server" here
> anymore.
>
> Reviewed-by: Hanna Czenczek <hre...@redhat.com>
> Signed-off-by: Thomas Huth <th...@redhat.com>
> ---
Added to the NBD queue.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
