Hanna Czenczek <hre...@redhat.com> writes:
> When exports are created on the command line (with the storage daemon),
> errp is going to point to error_fatal. Without ERRP_GUARD, we would
> exit immediately when *errp is set, i.e. skip the clean-up code under
> the `fail` label. Use ERRP_GUARD so we always run that code.
>
> As far as I know, this has no actual impact right now[1], but it is
> still better to make this right.
>
> [1] Not cleaning up the mount point is the only thing I can imagine
> would be problematic, but that is the last thing we attempt, so if
> it fails, it will clean itself up.
Hmm.
The pattern is "no cleanup with &error_fatal or &error_abort, but not
cleaning up then is harmless". How many instances do we have? My gut
feeling is in the hundreds. Why is "fixing" just this one worth the
bother?
> Signed-off-by: Hanna Czenczek <hre...@redhat.com>
> ---
> block/export/fuse.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/block/export/fuse.c b/block/export/fuse.c
> index a12f479492..7c035dd6ca 100644
> --- a/block/export/fuse.c
> +++ b/block/export/fuse.c
> @@ -119,6 +119,7 @@ static int fuse_export_create(BlockExport *blk_exp,
> BlockExportOptions *blk_exp_args,
> Error **errp)
> {
> + ERRP_GUARD(); /* ensure clean-up even with error_fatal */
> FuseExport *exp = container_of(blk_exp, FuseExport, common);
> BlockExportOptionsFuse *args = &blk_exp_args->u.fuse;
> int ret;
