On 04.03.25 12:17, Raman Dzehtsiar wrote:
This patch extends the blockdev-backup QMP command to allow users to specify
how to behave when IO errors occur during copy-before-write operations.
Previously, the behavior was fixed and could not be controlled by the user.
The new 'on-cbw-error' option can be set to one of two values:
- 'break-guest-write': Forwards the IO error to the guest and triggers
the on-source-error policy. This preserves snapshot integrity at the
expense of guest IO operations.
- 'break-snapshot': Allows the guest OS to continue running normally,
but invalidates the snapshot and aborts related jobs. This prioritizes
guest operation over backup consistency.
This enhancement provides more flexibility for backup operations in different
environments where requirements for guest availability versus backup
consistency may vary.
The default behavior remains unchanged to maintain backward compatibility.
Signed-off-by: Raman Dzehtsiar<raman.dzehts...@gmail.com>
Hi Raman, sorry for a delay!
The patch looks good to me. Still, could you also provide a test for a new
option?
Probably the simplest would be add a test-case to
`tests/qemu-iotests/tests/copy-before-write`, where existing on-cbw-error
option is tested. Or you can make a separate test.
--
Best regards,
Vladimir
