Am 12.03.2025 um 15:37 hat Markus Armbruster geschrieben: > bdrv_activate() returns failure without setting an error when > !bs->drv. This is suspicious. Turns out it used to succeed then, > until commit 5416645fcf82 changed it to return -ENOMEDIUM. > > Return zero instead. > > Fixes: 5416645fcf82 (block: return error-code from bdrv_invalidate_cache) > Signed-off-by: Markus Armbruster <arm...@redhat.com>
The commit message sounds more theoretical. Did you find this only by code inspection? Do we know what the effect on real-world cases is, so we could add a sentence about it to the commit message? Maybe we could even have a qemu-iotests case to show the effect? I absolutely agree that returning -ENOMEDIUM while not setting errp is wrong. But without an example of what is affected, it's not obvious to me which part of it needs to be fixed. Kevin
