On Sun, 2024-10-27 at 20:32 -0700, Guenter Roeck wrote: > On 10/27/24 15:26, Cédric Le Goater wrote: > > On 10/27/24 23:11, Guenter Roeck wrote: > > > On 10/27/24 14:13, Cédric Le Goater wrote: > > > > On 10/26/24 17:32, Guenter Roeck wrote: > > > > > On 10/26/24 03:02, Cédric Le Goater wrote: > > > > > [ ... ] > > > > > > > > > > > > > > > > Works for me, though, and it is much better than mandating the > > > > > existence > > > > > of boot partitions. > > > > > > > > Yes. However, if the emmc device was user creatable, we could use : > > > > > > > > -blockdev > > > > node-name=emmc0,driver=file,filename=mmc-ast2600-evb-noboot.raw \ > > > > -device emmc,bus=sdhci-bus.2,drive=emmc0 > > > > > > > > and with boot partitions: > > > > > > > > -M boot-emmc=true \ > > > > -blockdev node-name=emmc0,driver=file,filename=mmc-ast2600-evb.raw \ > > > > -device > > > > emmc,bus=sdhci-bus.2,drive=emmc0,boot-partition-size=1048576,boot-config=8 > > > > > > > > The above would be my preferred approach if acceptable. The "sd-bus" > > > > bus identifier should be changed in other machines tough. > > > > > > No real preference here, though my understanding is that emmc devices > > > are by definition built-in, and that is what emmc_class_init() says as > > > well. > > > Also, there does not seem to be an sdhci-bus, only sd-bus, and that does > > > not support any index values. That may be just my lack of knowledge, > > > though. > > > > No, you are right. On a real ast2600-evb, the eMMC device is indeed > > soldered on the board. But, for testing purposes, it is sometime > > interesting to add some flexibility in the machine definition and > > in the modeling too. This avoids "hard-coding" default devices in > > the machines and lets the user define its own variant models using > > the QEMU command line. > > I would agree, but I had a number of my patches rejected because while > they would be useful for testing they would not accurately reflect the > hardware. So nowadays I gave up even trying to upstream such changes.
My patch to make eMMCs user creatable [1] was applied to target- arm.next by Peter Maydell [2] last week. Jan [1] https://lore.kernel.org/qemu-devel/20241015135649.4189256-1-...@pengutronix.de/ [2] https://lore.kernel.org/qemu-devel/CAFEAcA9sjszCj=Fu-A-=qQV_jawnomJ-Nqnd=vx2vlkmyz1...@mail.gmail.com/ -- Pengutronix e.K. | | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
