On Sep 23 10:04, Keith Busch wrote: > On Fri, Aug 30, 2024 at 12:11:57PM -0700, Keith Busch wrote: > > From: Keith Busch <kbu...@kernel.org> > > > > The controller already supports this decoding, so just set the > > ID_CTRL.SGLS field accordingly. > > Hi Klaus, any concerns with this one? >
Hi Keith, No, sorry, just fell of my radar; thanks for the ping! I'll pick it up! Reviewed-by: Klaus Jensen <k.jen...@samsung.com> > > diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c > > index 5b1b0cabcf..68d4c19eda 100644 > > --- a/hw/nvme/ctrl.c > > +++ b/hw/nvme/ctrl.c > > @@ -8299,7 +8299,8 @@ static void nvme_init_ctrl(NvmeCtrl *n, PCIDevice > > *pci_dev) > > id->vwc = NVME_VWC_NSID_BROADCAST_SUPPORT | NVME_VWC_PRESENT; > > > > id->ocfs = cpu_to_le16(NVME_OCFS_COPY_FORMAT_0 | > > NVME_OCFS_COPY_FORMAT_1); > > - id->sgls = cpu_to_le32(NVME_CTRL_SGLS_SUPPORT_NO_ALIGN); > > + id->sgls = cpu_to_le32(NVME_CTRL_SGLS_SUPPORT_NO_ALIGN | > > + NVME_CTRL_SGLS_MPTR_SGL); > > > > nvme_init_subnqn(n); > > > > -- > > 2.43.5 > >
