On Thu, Jun 27, 2024 at 03:08:00PM +0900, Akihiko Odaki wrote: > rom_bar is tristate but was defined as uint32_t so convert it into > OnOffAuto. > > Signed-off-by: Akihiko Odaki <[email protected]>
Commit log should explain why this is an improvement, not just what's done. > diff --git a/docs/igd-assign.txt b/docs/igd-assign.txt > index e17bb50789ad..35c6c8e28493 100644 > --- a/docs/igd-assign.txt > +++ b/docs/igd-assign.txt > @@ -35,7 +35,7 @@ IGD has two different modes for assignment using vfio-pci: > ISA/LPC bridge device (vfio-pci-igd-lpc-bridge) on the root bus at > PCI address 1f.0. > * The IGD device must have a VGA ROM, either provided via the romfile > - option or loaded automatically through vfio (standard). rombar=0 > + option or loaded automatically through vfio (standard). rombar=off > will disable legacy mode support. > * Hotplug of the IGD device is not supported. > * The IGD device must be a SandyBridge or newer model device. ... > diff --git a/hw/vfio/pci-quirks.c b/hw/vfio/pci-quirks.c > index 39dae72497e0..0e920ed0691a 100644 > --- a/hw/vfio/pci-quirks.c > +++ b/hw/vfio/pci-quirks.c > @@ -33,7 +33,7 @@ > * execution as noticed with the BCM 57810 card for lack of a > * more better way to handle such issues. > * The user can still override by specifying a romfile or > - * rombar=1. > + * rombar=on. > * Please see https://bugs.launchpad.net/qemu/+bug/1284874 > * for an analysis of the 57810 card hang. When adding > * a new vendor id/device id combination below, please also add So we are apparently breaking a bunch of users who followed documentation to the dot. Why is this a good idea? -- MST
