On Thu 24 Mar 2016 05:39:23 PM CET, Paolo Bonzini wrote: > Extract the handling of throttling from bdrv_flush_io_queue. These > new functions will soon become BdrvChildRole callbacks, as they can > be generalized to "beginning of drain" and "end of drain". > > Signed-off-by: Paolo Bonzini <[email protected]>
I like the idea, thanks for the patch! Reviewed-by: Alberto Garcia <[email protected]> > +void bdrv_no_throttling_end(BlockDriverState *bs) > +{ > + --bs->io_limits_disabled; > } Not very important, but you could assert that this doesn't go below 0. Berto
