On 11/03/2015 03:32 AM, Alberto Garcia wrote:
> This patch removes the inner quotation marks in all cases like this:
>
> cmd=" ... "${variable}" ... "
>
> Signed-off-by: Alberto Garcia <[email protected]>
> ---
> tests/qemu-iotests/085 | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)Reviewed-by: Eric Blake <[email protected]> I might have worded the commit message differently, though: block: Remove incorrect "" in iotest 085 We had the patterns: cmd="..."${variable}"..." _send_qemu_cmd ... "..."${variable}"..." which is equivalent to using ${variable} unquoted. In the cmd= usage, that happened to be okay even though it is unusual (because no word splitting occurs on variable assignment); but where the usage appeared as an argument to _send_qemu_cmd, it was actively wrong (any whitespace in ${variable} would have caused word splitting). Fix it by removing the inner "", leaving ${variable} to be expanded inside the outer "" as desired. > @@ -152,7 +152,7 @@ echo === Invalid command - missing device and nodename === > echo > > _send_qemu_cmd $h "{ 'execute': 'blockdev-snapshot-sync', > - 'arguments': { > 'snapshot-file':'"${TEST_DIR}/1-${snapshot_virt0}"', > + 'arguments': { > 'snapshot-file':'${TEST_DIR}/1-${snapshot_virt0}', > 'format': 'qcow2' } }" "error" > Here's an example of the actual bug being fixed. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
