jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1332479?usp=email )
Change subject: tests: Keep ParamInfo format test dry
......................................................................
tests: Keep ParamInfo format test dry
Restore the edit action to the dummy ParamInfo response and register
all cached query submodules. Guard the membership checks against site
requests so fixture drift cannot escape to the network.
Bug: T381202
Change-Id: Iba9eb8e275f1fc28239736f775a260828855fb60
---
M tests/dry_api_tests.py
1 file changed, 14 insertions(+), 7 deletions(-)
Approvals:
jenkins-bot: Verified
Xqt: Looks good to me, approved
diff --git a/tests/dry_api_tests.py b/tests/dry_api_tests.py
index c78b022..21eb37e 100755
--- a/tests/dry_api_tests.py
+++ b/tests/dry_api_tests.py
@@ -291,7 +291,7 @@
dry = True
- #
https://en.wikipedia.org/w/api.php?action=paraminfo&modules=query+info|query+tokens
+ # ParamInfo data for the query+info, query+tokens, and edit modules.
paraminfodata = {
'paraminfo': {
'modules': [
@@ -355,6 +355,10 @@
'highlimit': 500
}
]
+ },
+ {
+ 'name': 'edit',
+ 'path': 'edit',
}
]
}
@@ -369,18 +373,21 @@
for mod in site._paraminfo.init_modules:
site._paraminfo._paraminfo[mod] = {}
site._paraminfo._action_modules = frozenset(['edit'])
- site._paraminfo._modules = {'query': frozenset(['info'])}
+ site._paraminfo._modules = {'query': frozenset(['info', 'tokens'])}
data = site._paraminfo.normalize_paraminfo(self.paraminfodata)
site._paraminfo._paraminfo.update(data)
def test_format(self) -> None:
"""Test using a dummy formatted in the new modules-only mode."""
pi = self.get_site()._paraminfo
- self.assertIn('query+info', pi._paraminfo)
- self.assertIn('query+tokens', pi._paraminfo)
- self.assertIn('edit', pi)
- self.assertIn('info', pi)
- self.assertIn('tokens', pi)
+ with patch.object(pi.site, '_request') as request:
+ self.assertIn('query+info', pi._paraminfo)
+ self.assertIn('query+tokens', pi._paraminfo)
+ self.assertIn('edit', pi._paraminfo)
+ self.assertIn('edit', pi)
+ self.assertIn('info', pi)
+ self.assertIn('tokens', pi)
+ request.assert_not_called()
def test_attribute(self) -> None:
"""Test using __getitem__."""
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1332479?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: Iba9eb8e275f1fc28239736f775a260828855fb60
Gerrit-Change-Number: 1332479
Gerrit-PatchSet: 2
Gerrit-Owner: Mahveotm <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
