jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1332215?usp=email )
Change subject: site: Fix loadrevisions step handling
......................................................................
site: Fix loadrevisions step handling
Call set_query_increment instead of replacing the method so that step controls
the API batch size.
Change-Id: I717b136b63a87ae76f58ab44125d37f8da07d5e6
---
M pywikibot/site/_generators.py
M tests/site_generators_tests.py
2 files changed, 13 insertions(+), 1 deletion(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/site/_generators.py b/pywikibot/site/_generators.py
index 54fe872..4667fe9 100644
--- a/pywikibot/site/_generators.py
+++ b/pywikibot/site/_generators.py
@@ -878,7 +878,7 @@
total=kwargs.get('total'), **rvargs)
if step:
- rvgen.set_query_increment = step
+ rvgen.set_query_increment(step)
if latest or 'revids' in rvgen.request:
rvgen.set_maximum_items(-1) # suppress use of rvlimit parameter
diff --git a/tests/site_generators_tests.py b/tests/site_generators_tests.py
index ed3611b..fb753a9 100755
--- a/tests/site_generators_tests.py
+++ b/tests/site_generators_tests.py
@@ -126,6 +126,18 @@
self.assertTrue(result)
namespace.assert_called_once_with()
+ def test_loadrevisions_step(self) -> None:
+ """Test that loadrevisions sets its API query increment."""
+ page = pywikibot.Page(self.site, 'Main Page')
+ with patch.object(self.site, '_generator') as generator:
+ rvgen = generator.return_value
+ set_query_increment = rvgen.set_query_increment
+ rvgen.request = {}
+ rvgen.__iter__.return_value = ()
+ self.site.loadrevisions(page, step=5)
+
+ set_query_increment.assert_called_once_with(5)
+
class TestSiteGenerators(DefaultSiteTestCase):
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1332215?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I717b136b63a87ae76f58ab44125d37f8da07d5e6
Gerrit-Change-Number: 1332215
Gerrit-PatchSet: 2
Gerrit-Owner: Mahveotm <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
