Xqt has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1328317?usp=email )
Change subject: weblinkchecker: Use deque for report queue
......................................................................
weblinkchecker: Use deque for report queue
Remove queued reports in constant time while preserving the existing FIFO order.
Change-Id: I747ba2b24c8146a0a2cdf9f5c2538cde8e3169ef
---
M scripts/weblinkchecker.py
1 file changed, 4 insertions(+), 3 deletions(-)
Approvals:
Xqt: Verified; Looks good to me, approved
diff --git a/scripts/weblinkchecker.py b/scripts/weblinkchecker.py
index c29f7fd..bb4edfc 100755
--- a/scripts/weblinkchecker.py
+++ b/scripts/weblinkchecker.py
@@ -114,6 +114,7 @@
import threading
import time
import urllib.parse as urlparse
+from collections import deque
from contextlib import suppress
from functools import partial
from http import HTTPStatus
@@ -455,7 +456,7 @@
"""Initializer."""
super().__init__()
self.semaphore = threading.Semaphore()
- self.queue = []
+ self.queue = deque()
self.finishing = False
self.killed = False
@@ -484,8 +485,8 @@
continue
with self.semaphore:
- url, error_report, containing_page, archive_url = self.queue[0]
- self.queue = self.queue[1:]
+ (url, error_report,
+ containing_page, archive_url) = self.queue.popleft()
talk_page = containing_page.toggleTalkPage()
pywikibot.info(
f'<<lightaqua>>** Reporting dead link on {talk_page}...')
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1328317?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I747ba2b24c8146a0a2cdf9f5c2538cde8e3169ef
Gerrit-Change-Number: 1328317
Gerrit-PatchSet: 2
Gerrit-Owner: Mahveotm <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
