Xqt has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1328287?usp=email )
Change subject: wikibase: Reuse qualifier identifier
......................................................................
wikibase: Reuse qualifier identifier
Retrieve the qualifier property identifier once when attaching a qualifier to a
claim.
Reuse it for lookup and insertion in the qualifier mapping.
Change-Id: I723b4d7811c6345b5f43918b24f7f487f5105369
---
M pywikibot/page/_wikibase.py
1 file changed, 4 insertions(+), 3 deletions(-)
Approvals:
Xqt: Verified; Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/page/_wikibase.py b/pywikibot/page/_wikibase.py
index 82d1027..7336a43 100644
--- a/pywikibot/page/_wikibase.py
+++ b/pywikibot/page/_wikibase.py
@@ -2114,10 +2114,11 @@
self.on_item.latest_revision_id = data['pageinfo']['lastrevid']
qualifier.on_item = self.on_item
qualifier.isQualifier = True
- if qualifier.getID() in self.qualifiers:
- self.qualifiers[qualifier.getID()].append(qualifier)
+ qualifier_id = qualifier.getID()
+ if qualifier_id in self.qualifiers:
+ self.qualifiers[qualifier_id].append(qualifier)
else:
- self.qualifiers[qualifier.getID()] = [qualifier]
+ self.qualifiers[qualifier_id] = [qualifier]
def removeQualifier(self, qualifier, **kwargs) -> None:
"""Remove the qualifier. Call removeQualifiers().
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1328287?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I723b4d7811c6345b5f43918b24f7f487f5105369
Gerrit-Change-Number: 1328287
Gerrit-PatchSet: 2
Gerrit-Owner: Mahveotm <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
