jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1326327?usp=email )
Change subject: pagegenerators: Reuse namespace during conversion
......................................................................
pagegenerators: Reuse namespace during conversion
Resolve each page's namespace and site namespace map once.
Reuse them while selecting the corresponding Page subclass.
Change-Id: I9635406a1d7bf2592d50166ef2e41d6d1b7d0e8f
---
M pywikibot/pagegenerators/__init__.py
1 file changed, 5 insertions(+), 3 deletions(-)
Approvals:
jenkins-bot: Verified
Xqt: Looks good to me, approved
diff --git a/pywikibot/pagegenerators/__init__.py
b/pywikibot/pagegenerators/__init__.py
index d0221d7..575f242 100644
--- a/pywikibot/pagegenerators/__init__.py
+++ b/pywikibot/pagegenerators/__init__.py
@@ -586,11 +586,13 @@
Category, FilePage, Userpage or Page.
"""
for page in generator:
- if page.namespace() == page.site.namespaces.USER:
+ namespace = page.namespace()
+ site_namespaces = page.site.namespaces
+ if namespace == site_namespaces.USER:
yield pywikibot.User(page)
- elif page.namespace() == page.site.namespaces.FILE:
+ elif namespace == site_namespaces.FILE:
yield pywikibot.FilePage(page)
- elif page.namespace() == page.site.namespaces.CATEGORY:
+ elif namespace == site_namespaces.CATEGORY:
yield pywikibot.Category(page)
else:
yield page
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1326327?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I9635406a1d7bf2592d50166ef2e41d6d1b7d0e8f
Gerrit-Change-Number: 1326327
Gerrit-PatchSet: 2
Gerrit-Owner: Mahveotm <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
