jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1326322?usp=email )
Change subject: wikibase: Reuse decoded reference claim IDs
......................................................................
wikibase: Reuse decoded reference claim IDs
Retrieve each decoded reference claim's property ID once.
Reuse it while grouping reference snaks by property.
Change-Id: I58ec5b87122499820ec2f8fa142624e80a6b001f
---
M pywikibot/page/_wikibase.py
1 file changed, 4 insertions(+), 3 deletions(-)
Approvals:
jenkins-bot: Verified
Xqt: Looks good to me, approved
diff --git a/pywikibot/page/_wikibase.py b/pywikibot/page/_wikibase.py
index 7ab1c56..82d1027 100644
--- a/pywikibot/page/_wikibase.py
+++ b/pywikibot/page/_wikibase.py
@@ -1887,9 +1887,10 @@
claim = cls.fromJSON(site, {'mainsnak': claimsnak,
'hash': data.get('hash')})
claim.isReference = True
- if claim.getID() not in source:
- source[claim.getID()] = []
- source[claim.getID()].append(claim)
+ claim_id = claim.getID()
+ if claim_id not in source:
+ source[claim_id] = []
+ source[claim_id].append(claim)
return source
@classmethod
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1326322?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I58ec5b87122499820ec2f8fa142624e80a6b001f
Gerrit-Change-Number: 1326322
Gerrit-PatchSet: 2
Gerrit-Owner: Mahveotm <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
