jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1325865?usp=email )
Change subject: site_detect: Parse legacy versions lazily
......................................................................
site_detect: Parse legacy versions lazily
Stop scanning API help after finding the first MediaWiki version line.
Avoid building a filtered list solely to retrieve one result.
Change-Id: I3390c4c83ade5cc54d8612dcdb05da6749e98bc7
---
M pywikibot/site_detect.py
1 file changed, 5 insertions(+), 4 deletions(-)
Approvals:
jenkins-bot: Verified
Xqt: Looks good to me, approved
diff --git a/pywikibot/site_detect.py b/pywikibot/site_detect.py
index 0c255b5..10e92c9 100644
--- a/pywikibot/site_detect.py
+++ b/pywikibot/site_detect.py
@@ -126,10 +126,11 @@
# Fallback for old versions which didn't wrap help in json
d = {'error': {'*': r.text}}
- self.version = list(filter(
- lambda x: x.startswith('MediaWiki'),
- (line.strip()
- for line in d['error']['*'].split('\n'))))[0].split()[1]
+ lines = (line.strip()
+ for line in d['error']['*'].split('\n'))
+ self.version = next(
+ line.split()[1] for line in lines
+ if line.startswith('MediaWiki'))
except Exception:
pass
else:
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1325865?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I3390c4c83ade5cc54d8612dcdb05da6749e98bc7
Gerrit-Change-Number: 1325865
Gerrit-PatchSet: 2
Gerrit-Owner: Mahveotm <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
