jenkins-bot has submitted this change. ( 
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1323976?usp=email )

Change subject: wrapper: Remove unused loop variables
......................................................................

wrapper: Remove unused loop variables

Record script arguments when selected and ignore the unused environment value 
during restoration.

Change-Id: I49389221846ad99d35a925120ce92f5a259d57d5
---
M pywikibot/scripts/wrapper.py
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  jenkins-bot: Verified
  Xqt: Looks good to me, approved




diff --git a/pywikibot/scripts/wrapper.py b/pywikibot/scripts/wrapper.py
index 0534a5e..b409f1d 100755
--- a/pywikibot/scripts/wrapper.py
+++ b/pywikibot/scripts/wrapper.py
@@ -165,7 +165,7 @@
 # end of snippet from coverage

         # Restore environment values
-        for key, value in environ:
+        for key, _ in environ:
             if key in old_env:
                 os.environ[key] = old_env[key]
             else:
@@ -186,6 +186,7 @@
     fname = None
     local = []
     env = []
+    script_args = args
     for index, arg in enumerate(args, start=1):
         if arg in ('-version', '--version'):
             fname = 'version.py'
@@ -201,11 +202,10 @@
             if not fname.endswith('.py'):
                 fname += '.py'
         if fname:
+            script_args = args[index:]
             break
-    else:
-        index = 0

-    return fname, list(args[index:]), local, env
+    return fname, list(script_args), local, env


 def _print_requirements(requirements,

--
To view, visit 
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1323976?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.wikimedia.org/r/settings?usp=email

Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I49389221846ad99d35a925120ce92f5a259d57d5
Gerrit-Change-Number: 1323976
Gerrit-PatchSet: 2
Gerrit-Owner: Mahveotm <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to