jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1323843?usp=email )
Change subject: tests: Isolate make_dist command-line arguments
......................................................................
tests: Isolate make_dist command-line arguments
Use a copy of sys.argv for every make_dist test and restore the original
through unittest cleanup. This prevents handle_args() from leaking its
rewritten argument list into later tests, including when an assertion fails.
Change-Id: Ib8f2bf15176c75f79e04bd868a25a2c75820cf7b
---
M tests/make_dist_tests.py
1 file changed, 7 insertions(+), 2 deletions(-)
Approvals:
jenkins-bot: Verified
Xqt: Looks good to me, approved
diff --git a/tests/make_dist_tests.py b/tests/make_dist_tests.py
index ea9d9f7..f837178 100755
--- a/tests/make_dist_tests.py
+++ b/tests/make_dist_tests.py
@@ -22,6 +22,12 @@
net = False
+ def setUp(self) -> None:
+ """Use an isolated command-line argument list for each test."""
+ super().setUp()
+ self.addCleanup(setattr, sys, 'argv', sys.argv)
+ sys.argv = sys.argv.copy()
+
def test_handle_args_empty(self) -> None:
"""Test make_dist handle_args function."""
args = make_dist.handle_args()
@@ -63,13 +69,12 @@
self.assertFalse(make_dist.main())
try:
- import build # noqa: autoflake
+ import build # noqa: F401
except ModuleNotFoundError:
# no build or twine modules
self.assertFalse(make_dist.main())
sys.argv = [*saved_argv, '-local']
self.assertFalse(make_dist.main())
- sys.argv = saved_argv
if __name__ == '__main__':
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1323843?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: Ib8f2bf15176c75f79e04bd868a25a2c75820cf7b
Gerrit-Change-Number: 1323843
Gerrit-PatchSet: 2
Gerrit-Owner: Mahveotm <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
