jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1314821?usp=email )
Change subject: tests: Update coverage for comms module
......................................................................
tests: Update coverage for comms module
Change-Id: I8f134b52abcc9b6432c02ec31e159e0830a316aa
---
M pywikibot/comms/eventstreams.py
M pywikibot/comms/http.py
2 files changed, 20 insertions(+), 7 deletions(-)
Approvals:
jenkins-bot: Verified
Xqt: Looks good to me, approved
diff --git a/pywikibot/comms/eventstreams.py b/pywikibot/comms/eventstreams.py
index f2bec13..401dfac 100644
--- a/pywikibot/comms/eventstreams.py
+++ b/pywikibot/comms/eventstreams.py
@@ -343,10 +343,13 @@
See the description of register_filter() how it works.
+ .. version-changed:: 8.6
+ Handle canary events coming from the Event Platform.
+
:param data: Event data dict used by filter functions
"""
if not self._canary and data.get('meta', {}).get('domain') == 'canary':
- return False # T266798
+ return False # pragma: no cover
if any(function(data) for function in self.filter['none']):
return False
@@ -375,7 +378,11 @@
try:
event = next(self.source)
- except (ProtocolError, OSError, httplib.IncompleteRead) as e:
+ except (
+ ProtocolError,
+ OSError,
+ httplib.IncompleteRead
+ ) as e: # pragma: no cover
warning(
f'Connection error: {e}.\nTry to re-establish connection.')
self.source.close()
@@ -388,16 +395,16 @@
if event.data:
try:
element = json.loads(event.data)
- except ValueError as e:
+ except ValueError as e: # pragma: no cover
warning(f'Could not load json data from\n{event}\n{e}')
else:
if self.streamfilter(element):
n += 1
yield element
# else: ignore empty message
- elif event.type == 'error':
+ elif event.type == 'error': # pragma: no cover
warning(f'Encountered error: {event.data}')
- else:
+ else: # pragma: no cover
warning(f'Unknown event {event.type} occurred.')
debug(f'{type(self).__name__}: Stopped iterating due to exceeding item'
diff --git a/pywikibot/comms/http.py b/pywikibot/comms/http.py
index fdcff85..a76965e 100644
--- a/pywikibot/comms/http.py
+++ b/pywikibot/comms/http.py
@@ -176,7 +176,13 @@
if key == 'revision':
return revision
- if key in ('code', 'lang', 'family', 'script_product', 'version'):
+ if key in (
+ 'code',
+ 'lang',
+ 'family',
+ 'script_product',
+ 'version'
+ ): # pragma: no cover
repl = replacements[key]
issue_deprecation_warning(
f'{{{key}}} value for user_agent',
@@ -283,7 +289,7 @@
return formatted.replace('()', '').replace(' ', ' ').strip()
-def fake_user_agent() -> str:
+def fake_user_agent() -> str: # pragma: no cover
"""Return a fake user agent."""
try:
from fake_useragent import UserAgent
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1314821?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I8f134b52abcc9b6432c02ec31e159e0830a316aa
Gerrit-Change-Number: 1314821
Gerrit-PatchSet: 2
Gerrit-Owner: Xqt <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
