jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1183221?usp=email )
Change subject: Test: convert TestSingleCodeFamilySite to dry test
......................................................................
Test: convert TestSingleCodeFamilySite to dry test
Replace `AlteredDefaultSiteTestCase` with `DefaultDrySiteTestCase`
to avoid network requests to translatewiki.net.
This prevents CI failures due to blocked connections while still
verifying family and site properties.
Bug: T403292
Change-Id: I0ff6b0dc8a80490ed6ae60cb701263005b841375
---
M tests/site_tests.py
1 file changed, 8 insertions(+), 12 deletions(-)
Approvals:
jenkins-bot: Verified
Xqt: Looks good to me, approved
diff --git a/tests/site_tests.py b/tests/site_tests.py
index 2eb6207..d463411 100755
--- a/tests/site_tests.py
+++ b/tests/site_tests.py
@@ -28,6 +28,7 @@
)
from tests.aspects import (
AlteredDefaultSiteTestCase,
+ DefaultDrySiteTestCase,
DefaultSiteTestCase,
DeprecationTestCase,
TestCase,
@@ -1039,28 +1040,23 @@
self.assertEqual(site.linktrail(), linktrail)
-class TestSingleCodeFamilySite(AlteredDefaultSiteTestCase):
+class TestSingleCodeFamilySite(DefaultDrySiteTestCase):
"""Test single code family sites."""
- sites = {
- 'i18n': {
- 'family': 'i18n',
- 'code': 'i18n',
- },
- }
+ family = 'i18n'
+ code = 'i18n'
def test_twn(self) -> None:
"""Test translatewiki.net."""
url = 'translatewiki.net'
- site = self.get_site('i18n')
- self.assertEqual(site.hostname(), url)
+ site = self.get_site()
self.assertEqual(site.code, 'i18n')
self.assertIsInstance(site.namespaces, Mapping)
self.assertFalse(site.obsolete)
- self.assertEqual(site.family.hostname('en'), url)
- self.assertEqual(site.family.hostname('i18n'), url)
- self.assertEqual(site.family.hostname('translatewiki'), url)
+ self.assertEqual(site.hostname(), url)
+ for code in 'en', 'i18n', 'translatewiki':
+ self.assertEqual(site.family.hostname(code), url)
class TestSubdomainFamilySite(TestCase):
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1183221?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I0ff6b0dc8a80490ed6ae60cb701263005b841375
Gerrit-Change-Number: 1183221
Gerrit-PatchSet: 2
Gerrit-Owner: Xqt <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
