Xqt has submitted this change. ( 
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1175572?usp=email )

Change subject: Revert "Tests: Enable coverage measurement in subprocesses 
started by execute_pwb()"
......................................................................

Revert "Tests: Enable coverage measurement in subprocesses started by 
execute_pwb()"

This reverts commit c13928ce53db4f462491204f4a1f0ba39863b83f.

Reason for revert: no improvements

Change-Id: Ib48240b5e2c47b1db6448ef98fdbf7d3fb850d1a
---
M .github/workflows/doctest.yml
M .github/workflows/login_tests-ci.yml
M .github/workflows/oauth_tests-ci.yml
M .github/workflows/pywikibot-ci.yml
M .github/workflows/sysop_write_tests-ci.yml
M .github/workflows/windows_tests.yml
M tests/utils.py
7 files changed, 0 insertions(+), 12 deletions(-)

Approvals:
  Xqt: Verified; Looks good to me, approved




diff --git a/.github/workflows/doctest.yml b/.github/workflows/doctest.yml
index 6c9b8b5..dee414e 100644
--- a/.github/workflows/doctest.yml
+++ b/.github/workflows/doctest.yml
@@ -68,7 +68,6 @@
           coverage run -m pytest pywikibot --doctest-modules 
--ignore-glob="*gui.py" --ignore-glob="*memento.py"
       - name: Show coverage statistics
         run: |
-          coverage combine
           coverage report
       - name: Upload coverage to Codecov
         uses: codecov/codecov-action@v5
diff --git a/.github/workflows/login_tests-ci.yml 
b/.github/workflows/login_tests-ci.yml
index fe66042..a8e35f1 100644
--- a/.github/workflows/login_tests-ci.yml
+++ b/.github/workflows/login_tests-ci.yml
@@ -124,7 +124,6 @@
           coverage run -m unittest -vv tests/site_login_logout_tests.py
       - name: Show coverage statistics
         run: |
-          coverage combine
           coverage report
       - name: Upload coverage to Codecov
         uses: codecov/codecov-action@v5
diff --git a/.github/workflows/oauth_tests-ci.yml 
b/.github/workflows/oauth_tests-ci.yml
index 008124b..0aa7e33 100644
--- a/.github/workflows/oauth_tests-ci.yml
+++ b/.github/workflows/oauth_tests-ci.yml
@@ -102,7 +102,6 @@
           coverage run -m unittest -vv
       - name: Show coverage statistics
         run: |
-          coverage combine
           coverage report
       - name: Upload coverage to Codecov
         uses: codecov/codecov-action@v5
diff --git a/.github/workflows/pywikibot-ci.yml 
b/.github/workflows/pywikibot-ci.yml
index dea4499..114fb7b 100644
--- a/.github/workflows/pywikibot-ci.yml
+++ b/.github/workflows/pywikibot-ci.yml
@@ -140,7 +140,6 @@
           fi
       - name: Show coverage statistics
         run: |
-          coverage combine
           coverage report
       - name: Upload coverage to Codecov
         uses: codecov/codecov-action@v5
diff --git a/.github/workflows/sysop_write_tests-ci.yml 
b/.github/workflows/sysop_write_tests-ci.yml
index 917ba22..a08b124 100644
--- a/.github/workflows/sysop_write_tests-ci.yml
+++ b/.github/workflows/sysop_write_tests-ci.yml
@@ -62,7 +62,6 @@
           coverage run -m pytest -s -r A -a "${{ matrix.attr }}"
       - name: Show coverage statistics
         run: |
-          coverage combine
           coverage report
       - name: Upload coverage to Codecov
         uses: codecov/codecov-action@v5
diff --git a/.github/workflows/windows_tests.yml 
b/.github/workflows/windows_tests.yml
index 579d45a..13a2405 100644
--- a/.github/workflows/windows_tests.yml
+++ b/.github/workflows/windows_tests.yml
@@ -75,7 +75,6 @@
           coverage run -m unittest discover -vv -p \"*_tests.py\";
       - name: Show coverage statistics
         run: |
-          coverage combine
           coverage report
       - name: Upload coverage to Codecov
         uses: codecov/codecov-action@v5
diff --git a/tests/utils.py b/tests/utils.py
index 1c69793..8f5d342 100644
--- a/tests/utils.py
+++ b/tests/utils.py
@@ -530,12 +530,6 @@
     else:
         command.append(_pwb_py)

-    # Test is running; activate coverage if present
-    if os.environ.get('PYWIKIBOT_TEST_RUNNING', '0') == '1':
-        with suppress(ModuleNotFoundError):
-            import coverage  # noqa: F401
-            command = [command[0], '-m', 'coverage', 'run'] + command[1:]
-
     return execute(command=command + args, data_in=data_in, timeout=timeout)



--
To view, visit 
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1175572?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.wikimedia.org/r/settings?usp=email

Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: Ib48240b5e2c47b1db6448ef98fdbf7d3fb850d1a
Gerrit-Change-Number: 1175572
Gerrit-PatchSet: 2
Gerrit-Owner: Xqt <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to